Skip to content

alibabacloud ipi private cluster (using cluster profile 'alibabacloud-qe') #31664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 5, 2022
Merged

alibabacloud ipi private cluster (using cluster profile 'alibabacloud-qe') #31664

openshift-merge-robot merged 1 commit into from
Dec 5, 2022

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Aug 25, 2022 •
edited
Loading

  1. add the workflow cucushift-installer-rehearse-alibabacloud-ipi-private and the chains of provision & deprovision (see JIRA ticket)
  2. add steps alibabacloud-{provision,deprovision}-vpc and alibabacloud-{provision,deprovision}-bastionhost
  3. use QE's cluster profile alibabacloud-qe
  4. note that there's a known bug, so that creating a private cluster would fail for now

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@jianli-wei jianli-wei force-pushed the ali-ipi-private branch 25 times, most recently from 035ea54 to c152109 Compare August 26, 2022 08:04
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Aug 29, 2022

/assign @hongkailiu

@bear-redhat
Copy link
Contributor

bear-redhat commented Sep 14, 2022

it looks like the rehearsal is failed due to unset values

@gpei
Copy link
Contributor

gpei commented Sep 14, 2022

@bear-redhat hi, as mentioned above(#31664 (comment)), the error was caused by a known issue - https://bugzilla.redhat.com/show_bug.cgi?id=2035720

@gpei
Copy link
Contributor

gpei commented Sep 14, 2022 •
edited
Loading

btw, @jianli-wei considering https://github.com/openshift/installer/pull/6265/files was merged, so we can remove the downloading aliyun-cli-linux-latest-amd64.tgz action in the steps, right?
please ignore, I see there's command checking in all the steps.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@gpei
Copy link
Contributor

gpei commented Sep 14, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@bear-redhat
Copy link
Contributor

bear-redhat commented Oct 3, 2022

rehearsal is failed. Do you want to fix it?

@bear-redhat
Copy link
Contributor

bear-redhat commented Oct 19, 2022

/uncc

@openshift-ci openshift-ci bot removed the request for review from bear-redhat October 19, 2022 13:51
@jianli-wei jianli-wei mentioned this pull request Dec 5, 2022
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022 •
edited
Loading

@jianli-wei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse f3c6c92b370582e47bc2a0460034ab89872c1e0d link false /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud f3c6c92b370582e47bc2a0460034ab89872c1e0d link unknown /test pj-rehearse
ci/prow/multi-arch-gen-valid f3c6c92b370582e47bc2a0460034ab89872c1e0d link true /test multi-arch-gen-valid
ci/prow/pr-reminder-config f3c6c92b370582e47bc2a0460034ab89872c1e0d link true /test pr-reminder-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor

jianlinliu commented Dec 5, 2022

@bear-redhat @hongkailiu do you mind to approve this PR, though there is a known issue, but it is the 1st step to add the install workflow, once the bug is fixed, we can quickly add the job into our ci grid.

@jianlinliu
Copy link
Contributor

jianlinliu commented Dec 5, 2022

/lgtm

@jianlinliu
Copy link
Contributor

jianlinliu commented Dec 5, 2022

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 5, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@hongkailiu
Copy link
Member

hongkailiu commented Dec 5, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6d9b66e into openshift:master Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@jianli-wei: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master__installer-rehearse-4.12.yaml using file ci-operator/config/openshift/verification-tests/openshift-verification-tests-master__installer-rehearse-4.12.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master-periodics.yaml using file ci-operator/jobs/openshift/verification-tests/openshift-verification-tests-master-periodics.yaml
Details

In response to this:

  1. add the workflow cucushift-installer-rehearse-alibabacloud-ipi-private and the chains of provision & deprovision (see JIRA ticket)
  2. add steps alibabacloud-{provision,deprovision}-vpc and alibabacloud-{provision,deprovision}-bastionhost
  3. use QE's cluster profile alibabacloud-qe
  4. note that there's a known bug, so that creating a private cluster would fail for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianli-wei jianli-wei deleted the ali-ipi-private branch December 6, 2022 01:51
@jianli-wei jianli-wei mentioned this pull request Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akostadinov akostadinov Awaiting requested review from akostadinov

1 more reviewer

@jianlinliu jianlinliu jianlinliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jianlinliu jianlinliu

@hongkailiu hongkailiu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jianli-wei @jianlinliu @bear-redhat @gpei @hongkailiu @openshift-ci-robot @openshift-merge-robot